On Mon, 16 Jun 2025, Markus Armbruster wrote:
Chao Liu <chao....@yeah.net> writes:
On 2025/6/16 13:55, Markus Armbruster wrote:
Chao Liu <lc00...@tecorigin.com> writes:
From: Chao Liu <chao....@yeah.net>
Hi, all:
After several rounds of discussion, I think that adding a -t option to the
`info mtree` command, which enables the display of tree-like node characters
(e.g., +--, |--), is a better approach.
As BALATON Zoltan pointed out, retaining space-based indentation for displaying
memory region (mr) nodes helps ensure that the output remains easily parseable
by other programs. This also provides better compatibility with existing tools
and scripts.
If people really feed the output of HMP info mtree to parsers, we should
probably provide the information via QMP.
Thank you for your helpful advice. I think the next step is to try implementing
"info mtree" via QMP first, and then have it called by HMP.
I’ve added it to my to-do list, and I’ll try to implement it using QMP in the
next phase.
First question before you actually do that: use cases for feeding the
information to programs? You might have answers already; I'm not on top
of prior conversations.
My request was to not make the output much wider than it is now as that
would result in broken lines and less readable output. The comment was not
about parsing output but keeping the result fit in not too wide terminals
as 64 bit addresses makes it wide already. Thus replacing spaces with tree
chars is OK with me as long as no new vertical space is added. The first
version of patch increased vertical space. Using ASCII chars was request
from somebody else but that makes the output look less nice so I'm not
sure it worth the change with that. Maybe leaving current output then
adding a separate tree mode with the original line drawing chars could
satisfy all preferences.
Regards,
BALATON Zoltan
