On 05/17/12 16:33, Luiz Capitulino wrote:
> @@ -291,8 +290,10 @@ int set_option_parameter(QEMUOptionParameter *list,
> const char *name,
> break;
>
> case OPT_SIZE:
> - if (parse_option_size(name, value, &list->value.n) == -1)
> - return -1;
> + parse_option_size(name, value, &list->value.n, &local_err);
> + if (error_is_set(&local_err)) {
> + goto exit_err;
> + }
> break;
>
> default:
> @@ -602,7 +603,8 @@ static int qemu_opt_parse(QemuOpt *opt)
> &local_err);
> break;
> case QEMU_OPT_SIZE:
> - return parse_option_size(opt->name, opt->str, &opt->value.uint);
> + parse_option_size(opt->name, opt->str, &opt->value.uint, &local_err);
> + break;
> default:
> abort();
> }
... and then the set_option_parameter() change would look like the
qemu_opt_parse() change (no if or goto). But it's fine.
Laszlo
