Re: [RFC PATCH RESEND 12/42] accel/split: Have thread routine ready to dispatch over HW/SW

[Richard Henderson]

On 6/20/25 10:27, Philippe Mathieu-Daudé wrote:

@@ -49,10 +56,12 @@ static void *split_cpu_thread_routine(void *arg)
      cpu->exit_request = 1;

do {

-        r = 0;
-
          if (cpu_can_run(cpu)) {
-            r = 0; /* TODO: exec_vcpu_thread() */
+            if (acs->use_hw) {
+                r = hwops->exec_vcpu_thread(cpu);
+            } else {
+                r = swops->exec_vcpu_thread(cpu);
+            }

Maybe

  AccelOpsClass *curops = acs->use_hw ? hwops : swops;
  r = curops->exec_vcpu_thread(cpu);

Anyway,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~