On Sun, 22 Jun 2025 at 00:53, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
>  tcg/tcg-op-gvec.c | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c
> index 1aad7b0864..451091753d 100644
> --- a/tcg/tcg-op-gvec.c
> +++ b/tcg/tcg-op-gvec.c
> @@ -534,9 +534,9 @@ static void do_dup_store(TCGType type, TCGv_ptr dbase, 
> uint32_t dofs,
>   * Only one of IN_32 or IN_64 may be set;
>   * IN_C is used if IN_32 and IN_64 are unset.
>   */

There's a doc comment just above here which needs to be
updated to say "at DBASE + DOFS", I think.

> -static void do_dup(unsigned vece, uint32_t dofs, uint32_t oprsz,
> -                   uint32_t maxsz, TCGv_i32 in_32, TCGv_i64 in_64,
> -                   uint64_t in_c)
> +static void do_dup(unsigned vece, TCGv_ptr dbase, uint32_t dofs,
> +                   uint32_t oprsz, uint32_t maxsz,
> +                   TCGv_i32 in_32, TCGv_i64 in_64, uint64_t in_c)

Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>

thanks
-- PMM

Reply via email to