Re: [PATCH 1/1] hw/s390x: Use preferred API call for IPLB chain write

[Richard Henderson]

On 6/23/25 13:12, jro...@linux.ibm.com wrote:

From: Jared Rossi <jro...@linux.ibm.com>

Replace a recently introduced legacy API call with the preferred API call.

fixes: 0927875 (hw/s390x: Build an IPLB for each boot device)
Signed-off-by: Jared Rossi <jro...@linux.ibm.com>
---
  hw/s390x/ipl.c | 10 +++++++++-
  1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index 2f082396c7..f2606303e6 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -399,8 +399,16 @@ static uint64_t s390_ipl_map_iplb_chain(IplParameterBlock 
*iplb_chain)
      uint16_t count = be16_to_cpu(ipl->qipl.chain_len);
      uint64_t len = sizeof(IplParameterBlock) * count;
      uint64_t chain_addr = find_iplb_chain_addr(ipl->bios_start_addr, count);
+    MemTxResult ret;
+
+    ret = address_space_write(&address_space_memory, chain_addr,
+            MEMTXATTRS_UNSPECIFIED, iplb_chain, len);
+
+    if (ret != MEMTX_OK) {
+        error_report("Failed to map IPLB chain.");
+        exit(1);
+    }

I'm certain you should not exit for a guest error.


r~

- cpu_physical_memory_write(chain_addr, iplb_chain, len);

      return chain_addr;
  }