Re: [PATCH v2 2/3] target/arm: Fix sve_access_check for SME

[Richard Henderson]

On 6/24/25 06:58, Peter Maydell wrote:

+    switch (dc_isar_feature(aa64_sme, s)) {
+    case true:

Why this rather than
        if (dc_isar_feature(aa64_sme, s)) {

?

+        if (s->pstate_sm) {
+            ret = sme_enabled_check(s);
+        } else if (!dc_isar_feature(aa64_sve, s)) {
+            ret = sme_sm_enabled_check(s);
+        } else {
+            break;
+        }

I used break instead of a goto, or replicating

+        if (ret) {
+            ret = nonstreaming_check(s);
+        }
          s->sve_access_checked = (ret ? 1 : -1);
          return ret;

this block.


r~