On Wed, Jun 25, 2025 at 10:02:50AM +0200, Cédric Le Goater wrote: > > +/* > > + * Process a received message. > > + */ > > +static void vfio_user_process(VFIOUserProxy *proxy, VFIOUserMsg *msg, > > + bool isreply) > > This routine could have an 'Error **errp' parameter and avoid the > error_printf() below. Can you fix that please ?
I could, but I think the current code makes more sense actually. vfio_user_process() handles a single message. If it's a reply with an error, we want to report it, but we don't want to tear down the device altogether. So it wouldn't make much sense for this particular routine to pass the error back to its caller? > > > + * For replies, find matching outgoing request and wake any waiters. > > + * For requests, queue in incoming list and run request BH. > > + */ > > +static int vfio_user_recv_one(VFIOUserProxy *proxy) > > I would add an 'Error **' parameter too ... This one I can do though regards john
