On Tue, Jul 01, 2025 at 05:45:07PM +0200, Magnus Kulke wrote:
> On Tue, Jul 01, 2025 at 03:11:39PM +0000, Wei Liu wrote:
> > On Tue, Jul 01, 2025 at 10:35:34AM +0200, Magnus Kulke wrote:
> > > On Tue, May 20, 2025 at 10:52:39PM +0000, Wei Liu wrote:
> > > > On Tue, May 20, 2025 at 01:30:17PM +0200, Magnus Kulke wrote:
> > > > > + default:
> > > > > + msg = &exit_msg;
> > > >
> > > > Do you not get any HALT exit? How are you going to shut down the VM?
> > > >
> > >
> > > In the WHPX accelerator there is this comment:
> > >
> > > case WHvRunVpExitReasonX64Halt:
> > > /*
> > > * WARNING: as of build 19043.1526 (21H1), this exit reason is
> > > no
> > > * longer used.
> > > */
> > > ret = whpx_handle_halt(cpu);
> > > break;
> > >
> > > I wonder if this also applies to HVMSG_X64_HALT from the MSHV driver?
> >
> > IIRC that's still used in our driver.
> >
> > You can try shutting down the VM with `poweroff` or `halt` and see if
> > you get the exit.
> >
> > Wei
>
> I wasn't able to trigger the exit with `poweroff` or `halt -p`. Or a
> kernel module that performs:
>
> ```
> local_irq_disable();
> __asm__("hlt");
> ```
>
> (it will just hang the guest).
>
> I have added the handler, but it looks like it's dead code currently.
We can leave the out for now as long as the guest shutdown works.
Wei.
