On Fri, 4 Jul 2025 at 17:57, Jackson Donaldson <jackson88...@gmail.com> wrote:
>
> This commit adds AES to max78000_soc
>
> Signed-off-by: Jackson Donaldson <jc...@duck.com>
> ---
> hw/arm/max78000_soc.c | 14 +++++++++++---
> include/hw/arm/max78000_soc.h | 2 ++
> 2 files changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/hw/arm/max78000_soc.c b/hw/arm/max78000_soc.c
> index 074fb1da8b..39ae4e0396 100644
> --- a/hw/arm/max78000_soc.c
> +++ b/hw/arm/max78000_soc.c
> @@ -45,6 +45,8 @@ static void max78000_soc_initfn(Object *obj)
>
> object_initialize_child(obj, "trng", &s->trng, TYPE_MAX78000_TRNG);
>
> + object_initialize_child(obj, "aes", &s->aes, TYPE_MAX78000_AES);
> +
> s->sysclk = qdev_init_clock_in(DEVICE(s), "sysclk", NULL, NULL, 0);
> }
>
> @@ -54,6 +56,7 @@ static void max78000_soc_realize(DeviceState *dev_soc,
> Error **errp)
> MemoryRegion *system_memory = get_system_memory();
> DeviceState *dev, *gcrdev, *armv7m;
> g_autofree char *trng_link = NULL;
> + g_autofree char *aes_link = NULL;
> SysBusDevice *busdev;
> Error *err = NULL;
> int i;
> @@ -137,6 +140,14 @@ static void max78000_soc_realize(DeviceState *dev_soc,
> Error **errp)
> trng_link = g_strdup("trng");
> object_property_set_link(OBJECT(gcrdev), trng_link, OBJECT(dev), &err);
>
> + dev = DEVICE(&s->aes);
> + sysbus_realize(SYS_BUS_DEVICE(dev), errp);
> + sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, 0x40007400);
> + sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, qdev_get_gpio_in(armv7m, 5));
> +
> + aes_link = g_strdup("aes");
> + object_property_set_link(OBJECT(gcrdev), aes_link, OBJECT(dev), &err);
Here again you can just pass "aes" as a direct argument.
Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
