On 7/11/25 16:46, Dmitry Osipenko wrote:
> On 6/17/25 07:32, Vivek Kasireddy wrote:
>> diff --git a/ui/console-gl.c b/ui/console-gl.c
>> index afb36dba64..403fc36fbd 100644
>> --- a/ui/console-gl.c
>> +++ b/ui/console-gl.c
>> @@ -184,6 +184,12 @@ void surface_gl_destroy_texture(QemuGLShader *gls,
>> }
>> glDeleteTextures(1, &surface->texture);
>> surface->texture = 0;
>> +#ifdef GL_EXT_memory_object_fd
>> + if (surface->mem_obj) {
>> + glDeleteMemoryObjectsEXT(1, &surface->mem_obj);
>> + surface->mem_obj = 0;
>> + }
>
> Nit: spec says that deleting surface->mem_obj=0 is ignored, hence the
> "if (surface->mem_obj)" check shouldn't be needed, like in a case with
> glDeleteTextures() above. That would make code look more consistent.
>
Otherwise looks fine
Reviewed-by: Dmitry Osipenko <[email protected]>
--
Best regards,
Dmitry
