Hi Michael, Cédric > From: Michael Tokarev <m...@tls.msk.ru> > Sent: Monday, July 28, 2025 3:12 PM > To: Jamin Lin <jamin_...@aspeedtech.com>; Cédric Le Goater <c...@kaod.org>; > Peter Maydell <peter.mayd...@linaro.org>; Steven Lee > <steven_...@aspeedtech.com>; Troy Lee <leet...@gmail.com>; Andrew > Jeffery <and...@codeconstruct.com.au>; Joel Stanley <j...@jms.id.au>; open > list:ASPEED BMCs <qemu-...@nongnu.org>; open list:All patches CC here > <qemu-devel@nongnu.org> > Cc: Troy Lee <troy_...@aspeedtech.com>; Hao Wu <wuhao...@google.com>; > Havard Skinnemoen <hskinnem...@google.com> > Subject: Re: [PATCH v1 19/21] pc-bios: Update AST27x0 vBootrom with SSP/TSP > SCU initialization support > > On 28.07.2025 10:02, Jamin Lin wrote: > > > It seems this patch fix this issue, > > https://patchwork.kernel.org/project/qemu-devel/patch/607a943a587248fb > > e0ff0897de80aee98a093caa.1753654515.git....@tls.msk.ru/ > > Yeah, I posted that patch yesterday after realizing our roms/vbootrom > submodule is outdated. > > > Do I need to update vbootrom/ast27x0/Makefile? > > I set "?=" to make user able to set variables in the command line. > > The prob with `CC ?=` construct is that CC variable is always set by make, so > this line becomes useless. The question mark should be removed, that's all. > > > 1. > > export CC=aarch64-linux-gnu-gcc > > make > > 2. make CC=aarch64-linux-gnu-gcc > > > > 3. Update Make file and user only need to issue "make" > > See how it's done in other subdirs of vbootrom. You only need to remove ? > from CC variable assignment. > > Distinction between 1 and 2 is `make -e` command-line switch. > > Thanks > Thanks for your help and support. I created a new pull request in google/vbootrom and waiting for google team review. Hao, Could you please help to review it? https://github.com/google/vbootrom/pull/10
Thanks-Jamin > /mjt
