On 7/30/25 13:52, Philippe Mathieu-Daudé wrote:
Hi Cédric,
On 30/7/25 08:39, Cédric Le Goater wrote:
Philippe,
On 7/30/25 06:58, Cédric Le Goater wrote:
Hello !
Michael provided changes to fix the build of the vbootrom image of the
AST2700 SoC machine in [1]. However, a workaound in roms/Makefile was
still necessary to build ast27x0_bootrom.bin correctly. This was later
fixed in [2].
This series is an update of [1] including a vbootrom image matching
the new commits.
Thanks,
C.
[1] https://lore.kernel.org/qemu-
devel/2a89ad4c8f5665d07952a4f1749caa6ec0cd3d9c.1753654515.git....@tls.msk.ru/
[2] https://github.com/google/vbootrom/
commit/7b1eb5f7fe6a85a03a1e40aa703a6ebbdb644e31
Changes in v3:
- Updated commit log in patch 3/3
Changes in v2:
- Updated all vbootrom images
Cédric Le Goater (1):
pc-bios: Update vbootrom image to commit 183c9ff8056b
Michael Tokarev (2):
roms/vbootrom: update to 7b1eb5f7fe6a
roms/Makefile: build ast27x0_bootrom
pc-bios/ast27x0_bootrom.bin | Bin 15552 -> 16408 bytes
pc-bios/npcm7xx_bootrom.bin | Bin 768 -> 672 bytes
pc-bios/npcm8xx_bootrom.bin | Bin 608 -> 672 bytes
roms/Makefile | 5 +++++
roms/vbootrom | 2 +-
5 files changed, 6 insertions(+), 1 deletion(-)
is pc-bios your juridiction ?
AFAICT pc-bios/ is nobody's juridiction =) I'm OK to merge generic
buildsys patches to help, but in that case I think that belongs to
Peter (ARM) or you (Aspeed), because I don't have an as
thoughtful test suite as you both do.
I ran the functional tests and make check but I am not sure they
cover correctly the ncpm* machines.
That said, if you don't have other PR pending and provide your
Ack-by tag, I can include them in my next PR (I likely will to
post one to fix a pair of SD card issues) -- but I expect Peter
to also have one...
OK. Let's see what happens in the next week before -rc2.
I think we should pull these changes in for QEMU 10.1.
No objection!
Great. We should wait for Hao to provide some feedback.
Thanks,
C.
