On 2025-07-30 14:48, Manos Pitsidianakis wrote: > Hi Alex, > > On Wed, Jul 30, 2025 at 4:19 PM Alex Bradbury <a...@igalia.com> wrote: >> >> This series contains one minor feature addition and a series of small >> bugfixes/improvements. The addition that motivates the submission is to add a >> limit argument for the hotblocks plugin, allowing you to control how many >> blocks are printed rather than being hardcoded to the 20 most executed. >> Setting limit=0 and dumping information about all executed blocks is >> incredibly helpful for an analysis script I have downstream. >> >> This is my first contribution to QEMU. I've attempted to follow all of the >> guidance in the "Submitting a Patch" guide, but apologies if I missed >> anything. >> >> Alex Bradbury (5): >> contrib/plugins/hotblocks: Correctly free sorted counts list >> contrib/plugins/hotblocks: Fix off by one error in iteration of sorted >> blocks >> contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than >> PRId64 >> docs/about/emulation: Add documentation for hotblocks plugin arguments >> contrib/plugins/hotblocks: Allow limit to be set as a command line >> argument >> >> contrib/plugins/hotblocks.c | 20 ++++++++++++++------ >> docs/about/emulation.rst | 12 ++++++++++++ >> 2 files changed, 26 insertions(+), 6 deletions(-) >> >> -- >> 2.50.1 >> >> > > I think the mailing list ate up your first patch. Not your fault > though. I did not receive it in my inbox and it's not on > lore.kernel.org either:
Thanks for taking a look - it seems like it's made it through now https://lore.kernel.org/qemu-devel/cf5a00136738b981a12270b76572e8d502daf208.1753857212.git....@igalia.com/ Best, Alex