On Thu, 31 Jul 2025 at 15:40, Cédric Le Goater <c...@redhat.com> wrote: > > hw/arm/virt.c should include 'system/system.h' for : > > serial_hd() > qemu_add_machine_init_done_notifier() > > Signed-off-by: Cédric Le Goater <c...@redhat.com> > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index > ef6be3660f5fb38da84235c32dc2d13a5c61889c..e1b6241f7bee4c2fddde31c512561e87229cebc2 > 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -50,6 +50,7 @@ > #include "system/kvm.h" > #include "system/hvf.h" > #include "system/qtest.h" > +#include "system/system.h" > #include "hw/loader.h" > #include "qapi/error.h" > #include "qemu/bitops.h"
Presumably we're currently pulling in this header indirectly via some other header (the vfio ones)? Might be helpful to say which. If this is a dependency for your vfio-platform removal patches, feel free to include it in there. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> -- PMM
