On 8/2/25 02:12, Pierrick Bouvier wrote:
My comment was related to vmstate_pstate64. Sorry it was confusing as I left the last
change concerning helper-a64.c, which was not related at all.
So the comment was that vmstate_cpsr already contains the lower 32 bits of pstate, and
thus we could save only the upper part in the new field.
That was part laziness. By saving the lower half twice, I can simply do
pstate_write(env, val)
to load the data, rather than
pstate_write(env, (val << 32) | pstate_read(env));
or something, to merge the halves.
r~
