On 8/6/25 21:13, Daniel P. Berrangé wrote:
It is best to have new functionality added in a separate commit from the removal of obsolete code.
My mistake - when Tanish and I "un-rebased" these patches from on top of yours, we placed the removal of the "nocheck" functions in patch 1 instead of patch 2 where it made more sense.
I've co-incidentally got removal of this obsolete code in the tracing test suite series I posted, so one will need to be rebased on top of the other, depending on what order Stefan wants to take the patches.
If the main blocker (the /dev/stdout issue) is fixed quickly, your patches should go in first because they aid in reviewing this one.
Tanish has started school again, so he'll probably concentrate on finishing what he has of the Rust work and I'll resubmit his patches later.
Paolo
