qemu_socket_select() and its wrapper qemu_socket_unselect() treat a
NULL @errp as &error_warn. This is wildly inappropriate. A caller
passing NULL specifies that errors are to be ignored. If warnings are
wanted, the caller must pass &error_warn.
I'm not familiar with the calling code, so I can't say whether it will
work after WSAEventSelect() failure. If it doesn't, then this should
be an error. If it does, then why bother the user with a warning that
isn't actionable, and likely confusing?
The warning goes back to commit f5fd677ae7cf (win32/socket: introduce
qemu_socket_select() helper). Before that commit, the error was
ignored, as indicated by passing a null @errp. Revert to that
behavior.
Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
util/oslib-win32.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index b7351634ec..136a8fe118 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -296,10 +296,6 @@ bool qemu_socket_select(int sockfd, WSAEVENT hEventObject,
{
SOCKET s = _get_osfhandle(sockfd);
- if (errp == NULL) {
- errp = &error_warn;
- }
-
if (s == INVALID_SOCKET) {
error_setg(errp, "invalid socket fd=%d", sockfd);
return false;
--
2.49.0
