Re: [RFC PATCH 11/11] target/arm/hvf: Allow EL2/EL3 emulation on Silicon M1 / M2

[Philippe Mathieu-Daudé]

On 12/8/25 02:23, Richard Henderson wrote:

On 8/12/25 03:06, Philippe Mathieu-Daudé wrote:

@@ -1014,11 +1015,14 @@ bool arm_hw_accel_cpu_feature_supported(enum arm_features feat, bool can_emulate

      case ARM_FEATURE_GENERIC_TIMER:
          return true;
      case ARM_FEATURE_EL2:
+        if (can_emulate) {
+            return true;
+        }
          ret = hv_vm_config_get_el2_supported(&supported);
          assert_hvf_ok(ret);
          return supported;
      case ARM_FEATURE_EL3:
-        return false;
+        return can_emulate && tcg_enabled();

Surely the el2 portion needs the tcg_enabled check as well.

Oops, indeed.