Re: [PATCH v6 04/13] hw/intc: Add hvf vGIC interrupt controller support

[Mohamed Mediouni]

> On 14. Aug 2025, at 14:57, Mads Ynddal <m...@ynddal.dk> wrote:
> 
> 
>> +static void hvf_gicv3_put(GICv3State *s)
>> +{
>> +    uint32_t reg;
>> +    uint64_t redist_typer;
>> +    int ncpu, i;
>> +
>> +    hvf_gicv3_check(s);
>> +
>> +    hv_vcpu_t vcpu0 = s->cpu[0].cpu->accel->fd;
>> +    hv_gic_get_redistributor_reg(vcpu0, HV_GIC_REDISTRIBUTOR_REG_GICR_TYPER
>> +        , &redist_typer);
>> +
> 
> I think you should go through all your "hv_" calls and do error handling
> where it's possible, and if not, at least check it with assert_hvf_ok.
> This call to hv_gic_get_redistributor_reg is failing on my setup. I
> don't know if there could be others.
> 
> I've configured my VM like this:
> -machine virt,kernel-irqchip=on,its=off
> -boot menu=on,splash-time=0
Will do this for my next revision. On which chip/macOS release did you see this 
failure?

-m