On Tue, Aug 19, 2025 at 9:28 PM Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> wrote: > > On 19.08.25 16:14, Lei Yang wrote: > > Hi Vladimir > > > > From the QE perspective, this series of patches cause a regression issues > > for multi queues: > > [qemu output] qemu-system-x86_64: -netdev ..."vhostfds": "20:21:22:23", > > "fds": "10:16:17:19" : vhostfds= is invalid if fds= wasn't specified > > Oh right, thanks, I see the mistake in "[PATCH 15/19] net/tap: introduce > net_tap_open()", I've refactored the end of net_init_tap() like it's only for > "open" case, but fds case doesn't have own "return" operator actually, and > goes to the end and fails on the last check. Will fix. > > Which tests should I execute? At least "make check" doesn't see this problem.
The test step is to use the qemu binary with the current patch applied to boot a guest that uses a multi-queues nic. I will test this series of patches again when you update to V2. > > > > > Thanks > > Lei > > > > > > On Tue, Aug 19, 2025 at 4:42 PM Vladimir Sementsov-Ogievskiy > > <vsement...@yandex-team.ru <mailto:vsement...@yandex-team.ru>> wrote: > > > > On 19.08.25 05:45, Jason Wang wrote: > > > On Mon, Aug 18, 2025 at 10:06 PM Vladimir Sementsov-Ogievskiy > > > <vsement...@yandex-team.ru <mailto:vsement...@yandex-team.ru>> wrote: > > >> > > >> Hi all! > > >> > > >> As preparation for further development of TAP live local migration > > >> (passing open fds through unix socket), > > > > > > I'm not sure I understand this, but I think it has been supported > > now, > > > or anything I miss? > > > > > > > Hmm, may be I missing something, but where? > > > > I see no code which put TAP fd into migration channel. Nothing about > > migration in tap.c at all. > > > > So, normally, to make local migration with TAP device, you have to > > create a new TAP for new QEMU > > process. > > > > I want to add a migration state, which will include needed part of > > TAPState, including fd, > > to continue using same TAP device in target process, avoiding also any > > initialization steps > > on that fd. > > > > -- > > Best regards, > > Vladimir > > > > > -- > Best regards, > Vladimir >
