Thomas Huth <th...@redhat.com> writes:
> On 20/08/2025 00.39, Fabiano Rosas wrote:
>> There's currently no OS level test for ppc64le. Add one such test by
>> reusing the boot level tests that are already present.
>>
>> The test boots the source machine, waits for it to reach a mid-boot
>> message, migrates and checks that the destination has reached the
>> final boot message (VFS error due to no disk).
>>
>> Signed-off-by: Fabiano Rosas <faro...@suse.de>
>> ---
>> tests/functional/test_ppc64_pseries.py | 41 ++++++++++++++++++++++++++
>> 1 file changed, 41 insertions(+)
>>
>> diff --git a/tests/functional/test_ppc64_pseries.py
>> b/tests/functional/test_ppc64_pseries.py
>> index 67057934e8..7a7e0fe8ae 100755
>> --- a/tests/functional/test_ppc64_pseries.py
>> +++ b/tests/functional/test_ppc64_pseries.py
>> @@ -9,6 +9,8 @@
>>
>> from qemu_test import QemuSystemTest, Asset
>> from qemu_test import wait_for_console_pattern
>> +from qemu_test.migration import Migration
>> +from qemu_test.ports import Ports
>>
>> class pseriesMachine(QemuSystemTest):
>>
>> @@ -87,5 +89,44 @@ def test_ppc64_linux_big_boot(self):
>> wait_for_console_pattern(self, console_pattern, self.panic_message)
>> wait_for_console_pattern(self, self.good_message,
>> self.panic_message)
>>
>> + def test_ppc64_linux_migration(self):
>> + with Ports() as ports:
>> + port = ports.find_free_port()
>> + if port is None:
>> + self.skipTest('Failed to find a free port')
>> + uri = 'tcp:localhost:%u' % port
>
> Hi,
>
> this is not how to use the context for Ports: Once the "with" block is left,
> the locking for the free port will be gone and you're subject to a race
> condition with other tests running in parallel (see the __enter__ and
> __exit__ methods in tests/functional/qemu_test/ports.py ... and yes, there
> should be more documentation for this).
>
Haha, I'm dumb. It never crossed my mind.
Thanks
