Hi Zhenzhong,
On 8/22/25 8:40 AM, Zhenzhong Duan wrote:
> When bypass_ro is true, readonly memory section is bypassed from
> mapping in the container.
>
> This is a preparing patch to workaround Intel ERRATA_772415.
I would explain what this ERRATA needs to implement
Thanks
Eric
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com>
> ---
> include/hw/vfio/vfio-container-base.h | 1 +
> hw/vfio/listener.c | 21 ++++++++++++++-------
> 2 files changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/include/hw/vfio/vfio-container-base.h
> b/include/hw/vfio/vfio-container-base.h
> index bded6e993f..31fd784d76 100644
> --- a/include/hw/vfio/vfio-container-base.h
> +++ b/include/hw/vfio/vfio-container-base.h
> @@ -51,6 +51,7 @@ typedef struct VFIOContainerBase {
> QLIST_HEAD(, VFIODevice) device_list;
> GList *iova_ranges;
> NotifierWithReturn cpr_reboot_notifier;
> + bool bypass_ro;
> } VFIOContainerBase;
>
> typedef struct VFIOGuestIOMMU {
> diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c
> index 903dfd8bf2..5fa2bb7f1a 100644
> --- a/hw/vfio/listener.c
> +++ b/hw/vfio/listener.c
> @@ -76,8 +76,13 @@ static bool vfio_log_sync_needed(const VFIOContainerBase
> *bcontainer)
> return true;
> }
>
> -static bool vfio_listener_skipped_section(MemoryRegionSection *section)
> +static bool vfio_listener_skipped_section(MemoryRegionSection *section,
> + bool bypass_ro)
> {
> + if (bypass_ro && section->readonly) {
> + return true;
> + }
> +
> return (!memory_region_is_ram(section->mr) &&
> !memory_region_is_iommu(section->mr)) ||
> memory_region_is_protected(section->mr) ||
> @@ -365,9 +370,9 @@ static bool
> vfio_known_safe_misalignment(MemoryRegionSection *section)
> }
>
> static bool vfio_listener_valid_section(MemoryRegionSection *section,
> - const char *name)
> + bool bypass_ro, const char *name)
> {
> - if (vfio_listener_skipped_section(section)) {
> + if (vfio_listener_skipped_section(section, bypass_ro)) {
> trace_vfio_listener_region_skip(name,
> section->offset_within_address_space,
> section->offset_within_address_space +
> @@ -494,7 +499,8 @@ void vfio_container_region_add(VFIOContainerBase
> *bcontainer,
> int ret;
> Error *err = NULL;
>
> - if (!vfio_listener_valid_section(section, "region_add")) {
> + if (!vfio_listener_valid_section(section, bcontainer->bypass_ro,
> + "region_add")) {
> return;
> }
>
> @@ -655,7 +661,8 @@ static void vfio_listener_region_del(MemoryListener
> *listener,
> int ret;
> bool try_unmap = true;
>
> - if (!vfio_listener_valid_section(section, "region_del")) {
> + if (!vfio_listener_valid_section(section, bcontainer->bypass_ro,
> + "region_del")) {
> return;
> }
>
> @@ -812,7 +819,7 @@ static void vfio_dirty_tracking_update(MemoryListener
> *listener,
> container_of(listener, VFIODirtyRangesListener, listener);
> hwaddr iova, end;
>
> - if (!vfio_listener_valid_section(section, "tracking_update") ||
> + if (!vfio_listener_valid_section(section, false, "tracking_update") ||
> !vfio_get_section_iova_range(dirty->bcontainer, section,
> &iova, &end, NULL)) {
> return;
> @@ -1206,7 +1213,7 @@ static void vfio_listener_log_sync(MemoryListener
> *listener,
> int ret;
> Error *local_err = NULL;
>
> - if (vfio_listener_skipped_section(section)) {
> + if (vfio_listener_skipped_section(section, false)) {
> return;
> }
>
