On 8/30/25 00:26, Daniel P. Berrangé wrote:
The catch-all exception handler forgot the placeholder for the exception details.Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- tests/functional/qemu_test/asset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py index b5a6136d36..5c74adf224 100644 --- a/tests/functional/qemu_test/asset.py +++ b/tests/functional/qemu_test/asset.py @@ -173,7 +173,7 @@ def fetch(self): continue except Exception as e: tmp_cache_file.unlink() - raise AssetError(self, "Unable to download: " % e) + raise AssetError(self, "Unable to download: %s" % e)if not os.path.exists(tmp_cache_file):raise AssetError(self, "Download retries exceeded", transient=True)
Isn't this exactly why f-strings are better, because you can't mess up the placeholders? Anyway, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
