On Mon, Sep 01, 2025 at 10:29:04AM +0000, Djordje Todorovic wrote: > Add RISC-V implementation of the Coherent Manager Global Control > Register (CMGCR) device. It is based on the existing MIPS CMGCR > implementation but adapted for RISC-V systems. > > The CMGCR device provides global system control for multi-core > configurations in RISC-V systems. > > This is needed for the MIPS BOSTON AIA board. > > Signed-off-by: Chao-ying Fu <c...@mips.com> > Signed-off-by: Djordje Todorovic <djordje.todoro...@htecgroup.com> > Reviewed-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com> > --- > hw/misc/Kconfig | 9 ++ > hw/misc/meson.build | 2 + > hw/misc/riscv_cmgcr.c | 244 ++++++++++++++++++++++++++++++++++ > include/hw/misc/riscv_cmgcr.h | 50 +++++++ > 4 files changed, 305 insertions(+) > create mode 100644 hw/misc/riscv_cmgcr.c > create mode 100644 include/hw/misc/riscv_cmgcr.h
> diff --git a/hw/misc/riscv_cmgcr.c b/hw/misc/riscv_cmgcr.c > new file mode 100644 > index 0000000000..1093eede19 > --- /dev/null > +++ b/hw/misc/riscv_cmgcr.c > @@ -0,0 +1,244 @@ > +/* > + * This file is subject to the terms and conditions of the GNU General Public > + * License. See the file "COPYING" in the main directory of this archive > + * for more details. > + * > + * Copyright (C) 2012 MIPS Technologies, Inc. All rights reserved. > + * Authors: Sanjay Lal <sanj...@kymasys.com> > + * > + * Copyright (C) 2015 Imagination Technologies > + * > + * Copyright (C) 2025 MIPS > + * > + * SPDX-License-Identifier: LGPL-2.1-or-later IIUC, you copied this from hw/misc/mips_cmgcr.c, which was GPL-2.0-or-later and so you can't claim this is LGPL-2.1-or-later. Since the orignial file didn't have a SPDX tag, don't add one to this new file - leave the original GPL copyright header untouched. > diff --git a/include/hw/misc/riscv_cmgcr.h b/include/hw/misc/riscv_cmgcr.h > new file mode 100644 > index 0000000000..d7145a51af > --- /dev/null > +++ b/include/hw/misc/riscv_cmgcr.h > @@ -0,0 +1,50 @@ > +/* > + * This file is subject to the terms and conditions of the GNU General Public > + * License. See the file "COPYING" in the main directory of this archive > + * for more details. > + * > + * Copyright (C) 2015 Imagination Technologies > + * > + * Copyright (C) 2025 MIPS > + * > + * SPDX-License-Identifier: LGPL-2.1-or-later Same point again With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|