On Wed, 10 Sept 2025 at 13:57, Igor Mammedov <imamm...@redhat.com> wrote: > > On Wed, 10 Sep 2025 13:23:10 +0200 > Paolo Bonzini <pbonz...@redhat.com> wrote: > > I've only looked at it briefly, but it fails on the bql_locked() > > assertion of xen_evtchn_set_gsi(). > > > > I think the assertion can be moved inside "if (gsi && gsi == > > s->callback_gsi)". > > given it's manipulating interrupts, > shouldn't we take BQL when doing so?
Yes, if you call qemu_irq_* then you must hold the BQL, because you can't guarantee what's on the other end and it may be assuming it has the BQL. -- PMM
