On 18.09.2025 12:20, Gerd Hoffmann wrote:
On Wed, Sep 17, 2025 at 05:23:55PM +0300, Michael Tokarev wrote:
Ping, also adding kraxel@.

Should I send formal patch moving one line of code up?

I'm wondering why this is needed in the first place?

We already have a smm machine property, and with smm
disabled all the smm-related memory regions should
stay disabled ...

I've a bug report stating that vga output does not work
with -machine q35,smm=off.  It is trivial to observe -
just run `qemu-system-x86_64 -machine q35,smm=off` --
you'll see an empty screen instead of seabios output
(after the commit in question).  Moving the "if..return"
line down one statement makes the output visible again.

I dunno if it actually *shuld* work (ie, there should be
an output on the guest screen).  If there shoudln't be,
okay, let's say it's an operator error.

I just don't know all these different cpu/machine features
and all their nuances.

Thanks,

/mjt

Reply via email to