On Mon, Sep 22, 2025 at 05:43:51AM +0000, Gustavo Romero wrote:
> reverse_debugging no longer depends on Avocado, so remove the import
> checks for Avocado, the per-arch endianness tweaks, and the per-arch
> register settings. All of these are now handled in the ReverseDebugging
> class.
>
> Signed-off-by: Gustavo Romero <gustavo.rom...@linaro.org>
> ---
> .../functional/aarch64/test_reverse_debug.py | 13 +++++--------
> tests/functional/ppc64/test_reverse_debug.py | 15 +++++----------
> tests/functional/x86_64/test_reverse_debug.py | 19 ++++++-------------
> 3 files changed, 16 insertions(+), 31 deletions(-)
>
> diff --git a/tests/functional/aarch64/test_reverse_debug.py
> b/tests/functional/aarch64/test_reverse_debug.py
> index 8bc91ccfde..7f816025a9 100755
> --- a/tests/functional/aarch64/test_reverse_debug.py
> +++ b/tests/functional/aarch64/test_reverse_debug.py
> @@ -1,26 +1,23 @@
> -#!/usr/bin/env python3
Please don't remove this - all the tests are expected to be directly
excecutable. (Same comment for the other files)
> -#
> # SPDX-License-Identifier: GPL-2.0-or-later
> #
> -# Reverse debugging test
> +# Reverse debugging test for aarch64
> #
> # Copyright (c) 2020 ISP RAS
> +# Copyright (c) 2025 Linaro Limited
> #
> # Author:
> # Pavel Dovgalyuk <pavel.dovgal...@ispras.ru>
> +# Gustavo Romero <gustavo.rom...@linaro.org> (Run without Avocado)
> #
> # This work is licensed under the terms of the GNU GPL, version 2 or
> # later. See the COPYING file in the top-level directory.
>
> -from qemu_test import Asset, skipIfMissingImports, skipFlakyTest
> +from qemu_test import Asset, skipFlakyTest
> from reverse_debugging import ReverseDebugging
>
>
> -@skipIfMissingImports('avocado.utils')
> class ReverseDebugging_AArch64(ReverseDebugging):
>
> - REG_PC = 32
> -
> ASSET_KERNEL = Asset(
> ('https://archives.fedoraproject.org/pub/archive/fedora/linux/'
> 'releases/29/Everything/aarch64/os/images/pxeboot/vmlinuz'),
> @@ -35,4 +32,4 @@ def test_aarch64_virt(self):
>
>
> if __name__ == '__main__':
> - ReverseDebugging.main()
> + ReverseDebugging_AArch64.main()
> diff --git a/tests/functional/ppc64/test_reverse_debug.py
> b/tests/functional/ppc64/test_reverse_debug.py
> index 5931adef5a..2b7b18e9a8 100755
> --- a/tests/functional/ppc64/test_reverse_debug.py
> +++ b/tests/functional/ppc64/test_reverse_debug.py
> @@ -1,41 +1,36 @@
> -#!/usr/bin/env python3
> -#
> # SPDX-License-Identifier: GPL-2.0-or-later
> #
> -# Reverse debugging test
> +# Reverse debugging test for ppc64
> #
> # Copyright (c) 2020 ISP RAS
> +# Copyright (c) 2025 Linaro Limited
> #
> # Author:
> # Pavel Dovgalyuk <pavel.dovgal...@ispras.ru>
> +# Gustavo Romero <gustavo.rom...@linaro.org> (Run without Avocado)
> #
> # This work is licensed under the terms of the GNU GPL, version 2 or
> # later. See the COPYING file in the top-level directory.
>
> -from qemu_test import skipIfMissingImports, skipFlakyTest
> +from qemu_test import skipFlakyTest
> from reverse_debugging import ReverseDebugging
>
>
> -@skipIfMissingImports('avocado.utils')
> class ReverseDebugging_ppc64(ReverseDebugging):
>
> - REG_PC = 0x40
> -
> @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/1992";)
> def test_ppc64_pseries(self):
> self.set_machine('pseries')
> # SLOF branches back to its entry point, which causes this test
> # to take the 'hit a breakpoint again' path. That's not a problem,
> # just slightly different than the other machines.
> - self.endian_is_le = False
> self.reverse_debugging()
>
> @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/1992";)
> def test_ppc64_powernv(self):
> self.set_machine('powernv')
> - self.endian_is_le = False
> self.reverse_debugging()
>
>
> if __name__ == '__main__':
> - ReverseDebugging.main()
> + ReverseDebugging_ppc64.main()
> diff --git a/tests/functional/x86_64/test_reverse_debug.py
> b/tests/functional/x86_64/test_reverse_debug.py
> index d713e91e14..408e5d1f48 100755
> --- a/tests/functional/x86_64/test_reverse_debug.py
> +++ b/tests/functional/x86_64/test_reverse_debug.py
> @@ -1,36 +1,29 @@
> -#!/usr/bin/env python3
> -#
> # SPDX-License-Identifier: GPL-2.0-or-later
> #
> -# Reverse debugging test
> +# Reverse debugging test for x86_64
> #
> # Copyright (c) 2020 ISP RAS
> +# Copyright (c) 2025 Linaro Limited
> #
> # Author:
> # Pavel Dovgalyuk <pavel.dovgal...@ispras.ru>
> +# Gustavo Romero <gustavo.rom...@linaro.org> (Run without Avocado)
> #
> # This work is licensed under the terms of the GNU GPL, version 2 or
> # later. See the COPYING file in the top-level directory.
>
> -from qemu_test import skipIfMissingImports, skipFlakyTest
> +from qemu_test import skipFlakyTest
> from reverse_debugging import ReverseDebugging
>
>
> -@skipIfMissingImports('avocado.utils')
> class ReverseDebugging_X86_64(ReverseDebugging):
>
> - REG_PC = 0x10
> - REG_CS = 0x12
> - def get_pc(self, g):
> - return self.get_reg_le(g, self.REG_PC) \
> - + self.get_reg_le(g, self.REG_CS) * 0x10
> -
> @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2922";)
> def test_x86_64_pc(self):
> self.set_machine('pc')
> - # start with BIOS only
> + # Start with BIOS only
> self.reverse_debugging()
>
>
> if __name__ == '__main__':
> - ReverseDebugging.main()
> + ReverseDebugging_X86_64.main()
> --
> 2.34.1
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
