> >> > +# @log: Firmware debug log, in base64 encoding.
> >>
> >> Can this have a partial line at the beginning and/or the end?
> >
> > Yes.
>
> Partial lines can be troublesome, in particular when complete lines
> start with a prefix in a known format. If avoiding them isn't
> practical, we should at least document.
The edk2 log has no structured format. I see this mainly as
trouble-shooting feature, where humans look at the output to diagnose
problems. I do not expect anyone parsing this automatically.
> >> > +{ 'struct': 'FirmwareLog',
> >> > + 'data': { '*version': 'str',
> >> > + '*log': 'str' } }
> >>
> >> These aren't actually optional with the current code. See [**] above.
> >> I guess you make them optional just in case some other firmware can
> >> provide only one of them.
> >
> > We could also make both mandatory. There is always the option to return
> > an empty string ...
>
> Yes. Loses the distinction between "firmware doesn't support this" and
> "firmware supports this, but it happens to be empty right now". Do we
> care?
See above, I don't think it matters much.
take care,
Gerd
