On 30/9/25 10:18, Zhao Liu wrote:
On Tue, Sep 30, 2025 at 09:50:24AM +0200, Philippe Mathieu-Daudé wrote:
Date: Tue, 30 Sep 2025 09:50:24 +0200
From: Philippe Mathieu-Daudé <[email protected]>
Subject: Re: [PATCH] subprojects: Update .gitignore for syn
On 30/9/25 09:53, Zhao Liu wrote:
The commit a530a8d4ac39 missed to update syn version, this is because
the code base of its v2 patch has fixed syn version, so that the fix for
syn were lost during the rebase from v1 to v2.
To rectify this mistake, update the syn version.
Fixes: a530a8d4ac39 ("subprojects: Update .gitignore for proc-macro2 and syn")
IIUC the subprojects is in commit 9a6d6ae8afb, so:
Fixes: 9a6d6ae8afb ("subprojects: update proc-macro2 and syn")
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
It's because the subject of a530a8d4ac39 mentioned to fix syn but it
actually didn't :-).
Commit a530a8d4ac39 mentions "update", not "fix".
The 'Fixes:' tag is helpful for downstream forks, to cherry-pick
relevant commits.
Fixes tag for 9a6d6ae8afb is also fine for me.
Thanks!
-Zhao
