From: Paolo Bonzini <[email protected]> chr_read() is printing an error message and returning with s->data_mutex taken. This can potentially cause a hang. Reported by Coverity.
Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Signed-off-by: Thomas Huth <[email protected]> (cherry picked from commit 3ee7f21ed292966f5cd3eb71aa06f8ffc0e5ae41) (Mjt: pick this trivial focused change up for 7.2.x so that subsequent fixes in this area applies cleanly) Signed-off-by: Michael Tokarev <[email protected]> diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index bf9f7c4248..e4f95b2858 100644 --- a/tests/qtest/vhost-user-test.c +++ b/tests/qtest/vhost-user-test.c @@ -351,7 +351,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size) if (size != msg.size) { qos_printf("%s: Wrong message size received %d != %d\n", __func__, size, msg.size); - return; + goto out; } } @@ -509,6 +509,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size) break; } +out: g_mutex_unlock(&s->data_mutex); } -- 2.47.3
