Hi Cédric,

Reviewed-by: Jae Hyun Yoo <[email protected]>

Thanks,
Jae

On 10/13/2025 05:44 AM, Cédric Le Goater wrote:
There are no functional tests for the 'qcom-dc-scm-v1-bmc' and
'qcom-firework-bmc' machines which makes harder to determine when
something becomes deprecated or unused.

Since the machines do not rely on any specific device models, they can
be replaced by the 'ast2600-evb' machine using the 'fmc-model' option
to specify the flash type. The I2C devices connected to the board can
be defined via the QEMU command line.

Cc: Jae Hyun Yoo <[email protected]>
Link: https://lore.kernel.org/qemu-devel/[email protected]
Signed-off-by: Cédric Le Goater <[email protected]>
---
  docs/about/deprecated.rst | 10 ++++++++++
  hw/arm/aspeed.c           |  2 ++
  2 files changed, 12 insertions(+)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index ce8fe9ac1be7..f6410037ead2 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -294,6 +294,16 @@ models, it can be replaced by the ``ast2500-evb`` machine 
using the
  ``fmc-model`` option to specify the flash type. The I2C devices
  connected to the board can be defined via the QEMU command line.

+Arm ``qcom-dc-scm-v1-bmc`` and ``qcom-firework-bmc`` machine (since 10.2)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+The ``qcom-dc-scm-v1-bmc`` and ``qcom-firework-bmc`` represent lab
+servers that never entered production. Since they do not rely on any
+specific device models, they can be replaced by the ``ast2600-evb``
+machine using the ``fmc-model`` option to specify the flash type. The
+I2C devices connected to the board can be defined via the QEMU command
+line.
+
  RISC-V default machine option (since 10.0)
  ''''''''''''''''''''''''''''''''''''''''''

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index d3a0c81f454f..0707a760fda6 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -1926,6 +1926,7 @@ static void 
aspeed_machine_qcom_dc_scm_v1_class_init(ObjectClass *oc,
      AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);

      mc->desc       = "Qualcomm DC-SCM V1 BMC (Cortex A7)";
+    mc->deprecation_reason = "use 'ast2600-evb' instead";
      amc->soc_name  = "ast2600-a3";
      amc->hw_strap1 = QCOM_DC_SCM_V1_BMC_HW_STRAP1;
      amc->hw_strap2 = QCOM_DC_SCM_V1_BMC_HW_STRAP2;
@@ -1945,6 +1946,7 @@ static void 
aspeed_machine_qcom_firework_class_init(ObjectClass *oc,
      AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);

      mc->desc       = "Qualcomm DC-SCM V1/Firework BMC (Cortex A7)";
+    mc->deprecation_reason = "use 'ast2600-evb' instead";
      amc->soc_name  = "ast2600-a3";
      amc->hw_strap1 = QCOM_DC_SCM_V1_BMC_HW_STRAP1;
      amc->hw_strap2 = QCOM_DC_SCM_V1_BMC_HW_STRAP2;
--
2.51.0



Reply via email to