Re: [PATCH v2 5/6] hw/hppa: Move CPU::cmdline_or_bootorder -> Machine::boot_info.gr24

[Richard Henderson]

On 10/9/25 23:18, Philippe Mathieu-Daudé wrote:

      } else {
          /* When booting via firmware, tell firmware if we want interactive
-         * mode (interactive_mode=1), and to boot from CD 
(cmdline_or_bootorder='d')
-         * or hard disc (cmdline_or_bootorder='c').
+         * mode (interactive_mode=1), and to boot from CD (bootorder='d')
+         * or hard disc (bootorder='c').
           */

Again there is no bootorder variable, so gr24 might be better.

@@ -685,7 +686,6 @@ static void hppa_machine_reset(MachineState *ms, ResetType 
type)
      memset(&hms->boot_info, 0, sizeof(hms->boot_info));
      cpu[0]->env.initrd_base = 0;
      cpu[0]->env.initrd_end = 0;
-    cpu[0]->env.cmdline_or_bootorder = 'c';
  }

You need to retain this store, but adjust to boot_info.gr24.


r~