Replace open() with qemu_open() which provides better error handling via the Error object, automatically sets O_CLOEXEC, and supports FD passing with /dev/fdset.
Remove redundant error_setg_file_open() call since qemu_open() now handles error reporting internally. Suggested-by: Daniel P. Berrangé <[email protected]> Signed-off-by: Vishal Chourasia <[email protected]> --- hw/core/loader.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 63bb0578b1..31d6cbf493 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -77,9 +77,8 @@ int64_t get_image_size(const char *filename, Error **errp) { int fd; int64_t size; - fd = open(filename, O_RDONLY | O_BINARY); + fd = qemu_open(filename, O_RDONLY | O_BINARY, errp); if (fd < 0) { - error_setg_file_open(errp, errno, filename); return -1; } size = lseek(fd, 0, SEEK_END); -- 2.51.0
