Re: [PATCH 2/9] target/hppa: Have hppa_form_gva*() return vaddr type

[Richard Henderson]

On 10/9/25 03:10, Philippe Mathieu-Daudé wrote:

Return a 'vaddr' type for "guest virtual address".

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  target/hppa/cpu.h        | 4 ++--
  target/hppa/helper.c     | 4 ++--
  target/hppa/mem_helper.c | 2 +-
  3 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
index 869a75876e2..e14f238827b 100644
--- a/target/hppa/cpu.h
+++ b/target/hppa/cpu.h
@@ -320,7 +320,7 @@ void hppa_translate_code(CPUState *cs, TranslationBlock *tb,

#define CPU_RESOLVING_TYPE TYPE_HPPA_CPU -static inline target_ulong hppa_form_gva_mask(uint64_t gva_offset_mask,

+static inline vaddr hppa_form_gva_mask(uint64_t gva_offset_mask,
                                          uint64_t spc, target_ulong off)

But indentation needs fixing on the second line.

  {
  #ifdef CONFIG_USER_ONLY
@@ -330,7 +330,7 @@ static inline target_ulong hppa_form_gva_mask(uint64_t 
gva_offset_mask,
  #endif
  }

-static inline target_ulong hppa_form_gva(CPUHPPAState *env, uint64_t spc,

+static inline vaddr hppa_form_gva(CPUHPPAState *env, uint64_t spc,
                                           target_ulong off)

Likewise.


r~