From: Daniel P. Berrangé <[email protected]> The standard python subprocess.check_call method is better than avocado.utils.process as it doesn't require stuffing all args into a single string.
Signed-off-by: Daniel P. Berrangé <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Reviewed-by: Thomas Huth <[email protected]> --- tests/functional/reverse_debugging.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/functional/reverse_debugging.py b/tests/functional/reverse_debugging.py index f9a1d395f1..a7ff47cb90 100644 --- a/tests/functional/reverse_debugging.py +++ b/tests/functional/reverse_debugging.py @@ -11,6 +11,7 @@ # later. See the COPYING file in the top-level directory. import os import logging +from subprocess import check_output from qemu_test import LinuxKernelTest, get_qemu_img from qemu_test.ports import Ports @@ -100,7 +101,6 @@ def vm_get_icount(vm): def reverse_debugging(self, shift=7, args=None): from avocado.utils import gdb - from avocado.utils import process logger = logging.getLogger('replay') @@ -111,8 +111,9 @@ def reverse_debugging(self, shift=7, args=None): if qemu_img is None: self.skipTest('Could not find "qemu-img", which is required to ' 'create the temporary qcow2 image') - cmd = '%s create -f qcow2 %s 128M' % (qemu_img, image_path) - process.run(cmd) + out = check_output([qemu_img, 'create', '-f', 'qcow2', image_path, '128M'], + encoding='utf8') + logger.info("qemu-img: %s" % out) replay_path = os.path.join(self.workdir, 'replay.bin') -- 2.34.1
