Filip Hejsek wrote on Sun, Sep 21, 2025 at 01:45:39AM +0200: > From: Szymon Lukasz <[email protected]> > > If a virtio serial port is a console port, forward terminal resize > messages from the chardev backend to the guest. > > Signed-off-by: Szymon Lukasz <[email protected]> > Signed-off-by: Filip Hejsek <[email protected]>
Nitpick below, but it works anyway: Reviewed-by: Dominique Martinet <[email protected]> Tested-by: Dominique Martinet <[email protected]> > diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c > index > 881c862ce9d12027f392031bdea7dbe280ec5493..0dd10a81f151b0606f6060ab2b4936117d81dd83 > 100644 > --- a/hw/char/virtio-console.c > +++ b/hw/char/virtio-console.c > + qemu_chr_fe_get_winsize(&vcon->chr, &cols, &rows); > + > + if (cols != vcon->cols || rows != vcon->rows) { given vcon cols/rows is initialized to -1 that means we'd send a 0,0 event if the chr size isn't set; would it make more sense to initialize to 0 as well? -- Dominique Martinet | Asmadeus
