On Mon, Sep 29, 2025 at 10:12:13AM +0800, Bin Guo wrote: > Adjust the positions of 'tls-authz' and 'max-postcopy-bandwidth' in > the fields output by the 'info migrate_parameters' command so that > related fields are next to each other. > > For clarity only, no functional changes. > > Sample output after this commit: > (qemu) info migrate_parameters > ... > max-cpu-throttle: 99 > tls-creds: '' > tls-hostname: '' > tls-authz: '' > max-bandwidth: 134217728 bytes/second > avail-switchover-bandwidth: 0 bytes/second > max-postcopy-bandwidth: 0 bytes/second
This can be moved even above "avail-switchover-bandwidth", IMHO. With that, feel free to take: Reviewed-by: Peter Xu <[email protected]> > downtime-limit: 300 ms > ... > > Signed-off-by: Bin Guo <[email protected]> > --- > migration/migration-hmp-cmds.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c > index 0fc21f0647..814221b260 100644 > --- a/migration/migration-hmp-cmds.c > +++ b/migration/migration-hmp-cmds.c > @@ -353,6 +353,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const > QDict *qdict) > monitor_printf(mon, "%s: '%s'\n", > MigrationParameter_str(MIGRATION_PARAMETER_TLS_HOSTNAME), > params->tls_hostname); > + assert(params->tls_authz); > + monitor_printf(mon, "%s: '%s'\n", > + MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ), > + params->tls_authz); > assert(params->has_max_bandwidth); > monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n", > MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH), > @@ -361,6 +365,10 @@ void hmp_info_migrate_parameters(Monitor *mon, const > QDict *qdict) > monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n", > > MigrationParameter_str(MIGRATION_PARAMETER_AVAIL_SWITCHOVER_BANDWIDTH), > params->avail_switchover_bandwidth); > + assert(params->has_max_postcopy_bandwidth); > + monitor_printf(mon, "%s: %" PRIu64 " bytes/second\n", > + > MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH), > + params->max_postcopy_bandwidth); > assert(params->has_downtime_limit); > monitor_printf(mon, "%s: %" PRIu64 " ms\n", > MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT), > @@ -383,12 +391,6 @@ void hmp_info_migrate_parameters(Monitor *mon, const > QDict *qdict) > monitor_printf(mon, "%s: %" PRIu64 " bytes\n", > MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE), > params->xbzrle_cache_size); > - monitor_printf(mon, "%s: %" PRIu64 "\n", > - > MigrationParameter_str(MIGRATION_PARAMETER_MAX_POSTCOPY_BANDWIDTH), > - params->max_postcopy_bandwidth); > - monitor_printf(mon, "%s: '%s'\n", > - MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ), > - params->tls_authz); > > if (params->has_block_bitmap_mapping) { > const BitmapMigrationNodeAliasList *bmnal; > -- > 2.39.5 > > -- Peter Xu
