HI Miguel,
On Thu, Oct 9, 2025 at 9:18 AM Miguel Luis <[email protected]> wrote: > > > > On 9 Oct 2025, at 05:42, Markus Armbruster <[email protected]> wrote: > > > > Miguel Luis <[email protected]> writes: > > > >> Hi Markus, > >> > >>> On 8 Oct 2025, at 12:33, Markus Armbruster <[email protected]> wrote: > >>> > >>> Salil Mehta <[email protected]> writes: > >>> > >>> [...] > >>> > >>>> =================== > >>>> (VIII) Repositories > >>>> =================== > >>>> > >>>> (*) Latest Qemu RFC V6 (Architecture Specific) patch set: > >>>> https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v6 > >>> > >>> Does not compile for me (x86_64 box running Fedora 41): > >>> > >>> [...] > >>> > >>> FAILED: qemu-system-loongarch64 > >>> cc -m64 @qemu-system-loongarch64.rsp > >>> /usr/bin/ld: > libsystem.a.p/hw_acpi_generic_event_device.c.o:(.data.rel+0x50): undefined > reference to `vmstate_cpu_ospm_state' > >>> collect2: error: ld returned 1 exit status > >>> [6757/7232] Linking target qemu-system-mips64 > >>> [6758/7232] Generating docs/QEMU manual with a custom command > >>> FAILED: docs/docs.stamp > >>> /usr/bin/env CONFDIR=etc/qemu > /work/armbru/qemu/bld/pyvenv/bin/sphinx-build -q -W -Dkerneldoc_werror=1 -j > auto -Dversion=10.1.50 -Drelease= -Ddepfile=docs/docs.d > -Ddepfile_stamp=docs/docs.stamp -b html -d > /work/armbru/qemu/bld/docs/manual.p /work/armbru/qemu/docs > /work/armbru/qemu/bld/docs/manual > >>> /work/armbru/qemu/docs/../include/hw/qdev-core.h:190: warning: > Function parameter or member 'admin_power_state_supported' not described in > 'DeviceClass' > >>> /work/armbru/qemu/docs/../include/hw/qdev-core.h:269: warning: Enum > value 'DEVICE_ADMIN_POWER_STATE_ENABLED' not described in enum > 'DeviceAdminPowerState' > >>> /work/armbru/qemu/docs/../include/hw/qdev-core.h:269: warning: Enum > value 'DEVICE_ADMIN_POWER_STATE_DISABLED' not described in enum > 'DeviceAdminPowerState' > >>> /work/armbru/qemu/docs/../include/hw/qdev-core.h:269: warning: Enum > value 'DEVICE_ADMIN_POWER_STATE_REMOVED' not described in enum > 'DeviceAdminPowerState' > >>> /work/armbru/qemu/docs/../include/hw/qdev-core.h:269: warning: Enum > value 'DEVICE_ADMIN_POWER_STATE_MAX' not described in enum > 'DeviceAdminPowerState' > >>> 1 warnings as Errors > >>> > >>> Warning, treated as error: > >>> kernel-doc 'perl /work/armbru/qemu/docs/../scripts/kernel-doc -rst > -enable-lineno -sphinx-version 7.3.7 -Werror > /work/armbru/qemu/docs/../include/hw/qdev-core.h' failed with return code 1 > >>> [6759/7232] Linking target qemu-system-i386 > >>> FAILED: qemu-system-i386 > >>> cc -m64 @qemu-system-i386.rsp > >>> /usr/bin/ld: > libsystem.a.p/hw_acpi_generic_event_device.c.o:(.data.rel+0x50): undefined > reference to `vmstate_cpu_ospm_state' > >>> collect2: error: ld returned 1 exit status > >>> > >>> [...] > >>> > >>> [6874/7232] Linking target qemu-system-x86_64 > >>> FAILED: qemu-system-x86_64 > >>> cc -m64 @qemu-system-x86_64.rsp > >>> /usr/bin/ld: > libsystem.a.p/hw_acpi_generic_event_device.c.o:(.data.rel+0x50): undefined > reference to `vmstate_cpu_ospm_state' > >>> collect2: error: ld returned 1 exit status > >>> > >> > >> I’ve had that same issue although it got compiled for me adding > ACPI_CPU_OSPM_INTERFACE for MICROVM: > >> > >> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > >> index 3a0e2b8ebb..29d9b09486 100644 > >> --- a/hw/i386/Kconfig > >> +++ b/hw/i386/Kconfig > >> @@ -133,6 +133,7 @@ config MICROVM > >> select VIRTIO_MMIO > >> select ACPI_PCI > >> select ACPI_HW_REDUCED > >> + select ACPI_CPU_OSPM_INTERFACE > >> select PCI_EXPRESS_GENERIC_BRIDGE > >> select USB_XHCI_SYSBUS > >> select I8254 > >> > >> Miguel > > > > Thanks for the hint. I additionally need a similar change to > > hw/loongarch/Kconfig, and comment hackery in hw/qdev-core.h. > > It seems that every arch selecting ACPI_HW_REDUCED must also select > ACPI_CPU_OSPM_INTERFACE or it fails building otherwise. > Thanks for debugging this. Something is not right about this dependency. > > > > >> > >>> [...] > >>> > >>> ninja: build stopped: cannot make progress due to previous errors. > >>> make: *** [Makefile:168: run-ninja] Error 1 > >>> make: Target 'all' not remade because of errors. > >>> make: Leaving directory '/work/armbru/qemu/bld' > >>> > >>> [...] > >>> > > > >
