On 25/10/17 04:56PM, Sourabh Jain wrote:
> 
> > <...snip...>
> > +    /*
> > +     * Mark next boot as fadump boot
> > +     *
> > +     * Note: These is some bit of assumption involved here, as PAPR doesn't
> > +     * specify any use of the dump status flags, nor does the kernel use it
> > +     *
> > +     * But from description in Table 136 in PAPR v2.13, it looks like:
> > +     *   FADUMP_STATUS_DUMP_TRIGGERED
> > +     *      = Dump was triggered by the previous system boot (PAPR says)
> > +     *      = Next boot will be a fadump boot (My perception)
> 
> Can we say assumption made or assumed instead of My perception.
> 
> > +     *
> > +     *   FADUMP_STATUS_DUMP_PERFORMED
> > +     *      = Dump performed (Set to 0 by caller of the
> > +     *        ibm,configure-kernel-dump call) (PAPR says)
> > +     *      = Firmware has performed the copying/dump of requested regions
> > +     *        (My perception)
> > +     *      = Dump is active for the next boot (My perception)
> 
> Same here.

Done. Thanks Sourabh !

- Aditya G



Reply via email to