Generally we want to clarify terminology and avoid confusions, prefering @start with (exclusive) @end, and base @addr with @length (for inclusive range).
Here as cpu_physical_memory_range_includes_clean() operates on a range, rename @start as @addr. Signed-off-by: Philippe Mathieu-Daudé <[email protected]> --- include/system/ram_addr.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/system/ram_addr.h b/include/system/ram_addr.h index 7a9e8f86be0..e06cc4d0c52 100644 --- a/include/system/ram_addr.h +++ b/include/system/ram_addr.h @@ -185,22 +185,22 @@ bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, unsigned client); bool cpu_physical_memory_is_clean(ram_addr_t addr); -static inline uint8_t cpu_physical_memory_range_includes_clean(ram_addr_t start, +static inline uint8_t cpu_physical_memory_range_includes_clean(ram_addr_t addr, ram_addr_t length, uint8_t mask) { uint8_t ret = 0; if (mask & (1 << DIRTY_MEMORY_VGA) && - !cpu_physical_memory_all_dirty(start, length, DIRTY_MEMORY_VGA)) { + !cpu_physical_memory_all_dirty(addr, length, DIRTY_MEMORY_VGA)) { ret |= (1 << DIRTY_MEMORY_VGA); } if (mask & (1 << DIRTY_MEMORY_CODE) && - !cpu_physical_memory_all_dirty(start, length, DIRTY_MEMORY_CODE)) { + !cpu_physical_memory_all_dirty(addr, length, DIRTY_MEMORY_CODE)) { ret |= (1 << DIRTY_MEMORY_CODE); } if (mask & (1 << DIRTY_MEMORY_MIGRATION) && - !cpu_physical_memory_all_dirty(start, length, DIRTY_MEMORY_MIGRATION)) { + !cpu_physical_memory_all_dirty(addr, length, DIRTY_MEMORY_MIGRATION)) { ret |= (1 << DIRTY_MEMORY_MIGRATION); } return ret; -- 2.51.0
