On 23/9/25 09:30, Philippe Mathieu-Daudé wrote:
On 23/9/25 04:39, Richard Henderson wrote:
Since 288a5fe980f, we don't link translation blocks
directly to palcode entry points.  If we load palbr
from env instead of encoding the constant, we avoid
all need for tb_flush().

Signed-off-by: Richard Henderson <[email protected]>
---
  target/alpha/helper.h     |  1 -
  target/alpha/sys_helper.c |  6 ------
  target/alpha/translate.c  | 21 ++++++---------------
  3 files changed, 6 insertions(+), 22 deletions(-)


Probably unrelated but still same target, could you also update the
comment added in commit fe57ca82b09 ("target-alpha: Add placeholders
for missing userspace PALcalls")?

         case 0x86:
             /* IMB */
             /* ??? We can probably elide the code using page_unprotect
                that is checking for self-modifying code.  Instead we
                could simply call tb_flush here.  Until we work out the
                changes required to turn off the extra write protection,
                this can be a no-op.  */
             break;


Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>


Reply via email to