On 08/10/2025 14.55, Daniel P. Berrangé wrote:
On Wed, Oct 08, 2025 at 01:55:12PM +0200, Thomas Huth wrote:
On 08/10/2025 13.35, Daniel P. Berrangé wrote:
This introduces new suits for running I/O tests on NBD and LUKS
drivers, giving new make targets
* make check-block-luks
* make check-block-nbd
Signed-off-by: Daniel P. Berrangé <[email protected]>
---
tests/qemu-iotests/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index 939a14ffae..5735d67c8c 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -23,7 +23,9 @@ qemu_iotests_formats = {
'raw': 'slow',
'qed': 'thorough',
'vmdk': 'thorough',
- 'vpc': 'thorough'
+ 'vpc': 'thorough',
+ 'nbd': 'thorough',
+ 'luks': 'thorough',
}
Before we do that, I'd first see a solution for the problem that I described
in my series here:
https://lore.kernel.org/qemu-devel/[email protected]/
which, by the way, contains a patch that is very similar to yours here.
IIUC, the problem you're concerned with is that 'make check SPEED=thorough'
is running too much, and you want to stop running skipped tests directly.
My view is that running "make check SPEED=thorough" is undesirable in
general, even before either of our patch series. I'd say it is almost
never what people actually want to use, and is only picked because of
the lack of a better option. That's why I thought 'make check-block-qed'
(and equiva for other formats) was a better option, as it gives a make
target that matches a specific testing use case. With that in mind, IMHO
it is less important if 'make check SPEED=thorough' waste a bit of time
launched irrelevant tests.
Sounds like you're only thinking about running iotests here. But what I
generally want to do: Run *all* tests at once, in parallel, on as many CPUs
as my host system provides, i.e. also qtests and functional tests in
parallel with the iotests. That's what you get with "make check
SPEED=thorough" only right now. And the output of that list is quite
cluttered with a lot of skipped iotests, which will only get much worse if
we add more formats to qemu_iotests_formats without any other patches.
Thomas
