Generally we want to clarify terminology and avoid confusions, prefering @start with (exclusive) @end, and base @addr with @length (for inclusive range).
Here as cpu_physical_memory_get_dirty() operates on a range, rename @start as @addr. Signed-off-by: Philippe Mathieu-Daudé <[email protected]> --- include/system/ram_addr.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/system/ram_addr.h b/include/system/ram_addr.h index f74a0ecee56..585ed78c767 100644 --- a/include/system/ram_addr.h +++ b/include/system/ram_addr.h @@ -142,7 +142,7 @@ static inline void qemu_ram_block_writeback(RAMBlock *block) #define DIRTY_CLIENTS_ALL ((1 << DIRTY_MEMORY_NUM) - 1) #define DIRTY_CLIENTS_NOCODE (DIRTY_CLIENTS_ALL & ~(1 << DIRTY_MEMORY_CODE)) -static inline bool cpu_physical_memory_get_dirty(ram_addr_t start, +static inline bool cpu_physical_memory_get_dirty(ram_addr_t addr, ram_addr_t length, unsigned client) { @@ -153,8 +153,8 @@ static inline bool cpu_physical_memory_get_dirty(ram_addr_t start, assert(client < DIRTY_MEMORY_NUM); - end = TARGET_PAGE_ALIGN(start + length) >> TARGET_PAGE_BITS; - page = start >> TARGET_PAGE_BITS; + end = TARGET_PAGE_ALIGN(addr + length) >> TARGET_PAGE_BITS; + page = addr >> TARGET_PAGE_BITS; WITH_RCU_READ_LOCK_GUARD() { blocks = qatomic_rcu_read(&ram_list.dirty_memory[client]); -- 2.51.0
