Hi
On 10/21/25 06:54, Harsh Prateek Bora wrote:
+Cedric
Hi Phillipe,
It had been done and the patches were reviewed already here (you were in CC
too):
https://lore.kernel.org/qemu-devel/[email protected]/
I would take the already reviewed patches, as that work is done. This series
is fine, but it is extra effort for removing dead code, which isn't worth
the time.
Thanks,
C.
Let us try to avoid duplication of implementation/review efforts.
If the motivation to re-do is just to split, I think let us consider the
original series to avoid duplication of review efforts. I should probably send
more frequent PRs to avoid such scenarios in future.
Thanks for your contribution in reviewing other patches though. It's highly
appreciated.
regards,
Harsh
On 10/20/25 16:07, Philippe Mathieu-Daudé wrote:
Remove the deprecated pseries-3.0 up to pseries-4.2 machines,
which are older than 6 years. Remove resulting dead code.
Philippe Mathieu-Daudé (18):
hw/ppc/spapr: Remove deprecated pseries-3.0 machine
hw/ppc/spapr: Remove SpaprMachineClass::spapr_irq_xics_legacy field
hw/ppc/spapr: Remove SpaprMachineClass::legacy_irq_allocation field
hw/ppc/spapr: Remove SpaprMachineClass::nr_xirqs field
hw/ppc/spapr: Remove deprecated pseries-3.1 machine
hw/ppc/spapr: Remove SpaprMachineClass::broken_host_serial_model field
target/ppc/kvm: Remove kvmppc_get_host_serial() as unused
target/ppc/kvm: Remove kvmppc_get_host_model() as unused
hw/ppc/spapr: Remove SpaprMachineClass::dr_phb_enabled field
hw/ppc/spapr: Remove SpaprMachineClass::update_dt_enabled field
hw/ppc/spapr: Remove deprecated pseries-4.0 machine
hw/ppc/spapr: Remove SpaprMachineClass::pre_4_1_migration field
hw/ppc/spapr: Remove SpaprMachineClass::phb_placement callback
hw/ppc/spapr: Remove deprecated pseries-4.1 machine
hw/ppc/spapr: Remove SpaprMachineClass::smp_threads_vsmt field
hw/ppc/spapr: Remove SpaprMachineClass::linux_pci_probe field
hw/ppc/spapr: Remove deprecated pseries-4.2 machine
hw/ppc/spapr: Remove SpaprMachineClass::rma_limit field
include/hw/ppc/spapr.h | 16 --
include/hw/ppc/spapr_irq.h | 1 -
target/ppc/kvm_ppc.h | 12 --
hw/ppc/spapr.c | 298 ++++++++-----------------------------
hw/ppc/spapr_caps.c | 6 -
hw/ppc/spapr_events.c | 20 +--
hw/ppc/spapr_hcall.c | 5 -
hw/ppc/spapr_irq.c | 36 +----
hw/ppc/spapr_pci.c | 32 +---
hw/ppc/spapr_vio.c | 9 --
target/ppc/kvm.c | 11 --
11 files changed, 75 insertions(+), 371 deletions(-)
