On Tue, 21 Oct 2025 at 17:16, Peter Xu <[email protected]> wrote: > > On Tue, Oct 21, 2025 at 04:43:52PM +0100, Peter Maydell wrote: > > Do you have plans for further cleanup/extension of the > > use of Error here that would let these functions pass > > the Error back up the chain ? > > It would be non-trivial though as we'll need to change VMStateInfo.get() > API and that'll be another lot of churns.
We could at least do it in stages, so we add new fields .get_err and .put_err that have the new API with Error*; the calling code in migration/ uses the new functions if they're non-NULL, otherwise falling back to the old ones. Then we only need to update the implementations which want to be able to return an Error. (This is the same sort of thing we have with MemoryRegionOps and its read/write vs read_with_attrs/write_with_attrs methods.) The downside is we end up with another "there's two ways you can do this" API. -- PMM
