On 10/20/2025 9:20 AM, [email protected] wrote:
From: Jared Rossi<[email protected]> Enable virt-queue PCI configuration and add routines for virtio-blk-pci devices. Signed-off-by: Jared Rossi<[email protected]> ---
Just a general observation in this patch, the BAR we are reading and writing to is BAR 4 for the virtio device. I think QEMU defines all the structure in BAR 4 (https://github.com/qemu/qemu/blob/88f72048d2f5835a1b9eaba690c7861393aef283/hw/virtio/virtio-pci.c#L2169). But after looking through the virtio spec, I couldn't tell if BAR 4 is hardcoded in the spec and should be used by default. So maybe we should try to read the BAR number from what the device provides to be more spec compliant? If we think that its okay to just use BAR 4 for now, then we should at least have a #define for it (also for magic number 15 which is a zpci address space number for PCI config space).
Thanks Farhan
