> -----Original Message-----
> From: Eric Auger <[email protected]>
> Sent: 27 October 2025 10:42
> To: Jonathan Cameron <[email protected]>; Shameer
> Kolothum <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Jason Gunthorpe <[email protected]>; Nicolin Chen
> <[email protected]>; [email protected]; [email protected]; Nathan
> Chen <[email protected]>; Matt Ochs <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH v4 14/27] hw/arm/smmuv3-accel: Get host SMMUv3 hw
> info and validate
>
[...]
> >> + val = FIELD_EX32(info->idr[0], IDR0, STLEVEL);
> >> + if (val != FIELD_EX32(s->idr[0], IDR0, STLEVEL)) {
> >> + s->idr[0] = FIELD_DP32(s->idr[0], IDR0, STLEVEL, val);
> > This seems a rather odd side effect to have. Perhaps a comment on why
> > in error path it make sense to change s->idr[0]?
> also consider s->idr[] are not migrated. I know there is a migration blocker
> set
> in 20/27 though. I would simply return an error here.
That idr[0] update is a mistake from rework/rebase and is not required.
[...]
> >> + /* QEMU SMMUv3 supports Range Invalidation by default */
> >> + val = FIELD_EX32(info->idr[3], IDR3, RIL);
> >> + if (val != FIELD_EX32(s->idr[3], IDR3, RIL)) {
> >> + error_setg(errp, "Host SUMMUv3 deosn't support Range
> >> + Invalidation");
> > doesn't.
> as Jonathan suggested you might avoid using the local var here too and below
Done.
Thanks,
Shameer
