Re: [PATCH] hw/pci-host: Set DEVICE_CATEGORY_BRIDGE once in parent class_init()

[Philippe Mathieu-Daudé]

On 28/10/25 08:16, Marc-André Lureau wrote:

On Mon, Oct 27, 2025 at 3:37 PM Philippe Mathieu-Daudé
<phi...@linaro.org> wrote:

No need to set DEVICE_CATEGORY_BRIDGE for each device
implementing TYPE_PCI_HOST_BRIDGE: set it once in the
parent.

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>

this will also categorize a bunch of devices

Indeed:

$ git grep -l parent.*TYPE_PCI_HOST_BRIDGE
hw/alpha/typhoon.c
hw/pci-bridge/pci_expander_bridge.c
hw/pci-host/articia.c
hw/pci-host/astro.c
hw/pci-host/bonito.c
hw/pci-host/designware.c
hw/pci-host/dino.c
hw/pci-host/grackle.c
hw/pci-host/gt64120.c
hw/pci-host/i440fx.c
hw/pci-host/mv64361.c
hw/pci-host/ppc440_pcix.c
hw/pci-host/ppc4xx_pci.c
hw/pci-host/ppce500.c
hw/pci-host/raven.c
hw/pci-host/sabre.c
hw/pci-host/sh_pci.c
hw/pci-host/uninorth.c
hw/pci-host/versatile.c
hw/pci/pcie_host.c
hw/ppc/spapr_pci.c
hw/s390x/s390-pci-bus.c

So the following ones are categorized:

hw/alpha/typhoon.c
hw/pci-bridge/pci_expander_bridge.c
hw/pci-host/astro.c
hw/pci-host/bonito.c
hw/pci-host/dino.c
hw/pci-host/i440fx.c
hw/pci-host/ppc440_pcix.c
hw/pci-host/ppc4xx_pci.c
hw/pci-host/sh_pci.c
hw/pci-host/versatile.c
hw/pci/pcie_host.c
hw/ppc/spapr_pci.c
hw/s390x/s390-pci-bus.c

I'll update the description.

Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>

Thanks!

---
  hw/pci-host/articia.c     | 1 -
  hw/pci-host/aspeed_pcie.c | 1 -
  hw/pci-host/designware.c  | 3 ---
  hw/pci-host/gpex.c        | 2 --
  hw/pci-host/grackle.c     | 1 -
  hw/pci-host/gt64120.c     | 1 -
  hw/pci-host/mv64361.c     | 1 -
  hw/pci-host/pnv_phb.c     | 1 -
  hw/pci-host/ppce500.c     | 1 -
  hw/pci-host/q35.c         | 1 -
  hw/pci-host/raven.c       | 1 -
  hw/pci-host/remote.c      | 1 -
  hw/pci-host/sabre.c       | 1 -
  hw/pci-host/uninorth.c    | 4 ----
  hw/pci-host/xilinx-pcie.c | 2 --
  hw/pci/pci_host.c         | 1 +
  16 files changed, 1 insertion(+), 22 deletions(-)