On 28/10/2025 19.12, Philippe Mathieu-Daudé wrote:
SysBusDevice::mmio[] is private data of SysBusDevice, use
sysbus_mmio_get_region() to access it.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
hw/i386/microvm-dt.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c
index cb27dfd732e..d7f49bc1b5f 100644
--- a/hw/i386/microvm-dt.c
+++ b/hw/i386/microvm-dt.c
@@ -71,7 +71,8 @@ static void dt_add_virtio(MicrovmMachineState *mms,
VirtIOMMIOProxy *mmio)
return;
}
- hwaddr base = dev->mmio[0].addr;
+ MemoryRegion *mr = sysbus_mmio_get_region(dev, 0);
+ hwaddr base = mr->addr;
hwaddr size = 512;
unsigned index = (base - VIRTIO_MMIO_BASE) / size;
uint32_t irq = mms->virtio_irq_base + index;
@@ -150,7 +151,8 @@ static void dt_add_pcie(MicrovmMachineState *mms)
static void dt_add_ioapic(MicrovmMachineState *mms, SysBusDevice *dev)
{
- hwaddr base = dev->mmio[0].addr;
+ MemoryRegion *mr = sysbus_mmio_get_region(dev, 0);
+ hwaddr base = mr->addr;
char *nodename;
uint32_t ph;
int index;
Wouldn't it make sense to move patch 11 before this patch, and then to use
memory_region_get_address() here directly?
Thomas
