On 29.10.25 14:18, Philippe Mathieu-Daudé wrote:
On 29/10/25 09:28, David Hildenbrand wrote:
@@ -510,11 +514,12 @@ static MemTxResult
zpci_write_bar(S390PCIBusDevice *pbdev, uint8_t pcias,
uint64_t offset, uint64_t data,
uint8_t len)
{
MemoryRegion *mr;
+ hwaddr subregion_base_addr;
mr = pbdev->pdev->io_regions[pcias].memory;
mr = s390_get_subregion(mr, offset, len);
- offset -= mr->addr;
- return memory_region_dispatch_write(mr, offset, data,
+ subregion_base_addr = memory_region_get_address(mr);
Any partixular reason for the temp variable?
To fit the 72-80 chars per line limit. Since various people
asked the same, I'll just replace in place, ignoring the
checkpatch.pl warnings.
I was wondering about a simple
offset -= memory_region_get_address(mr);
by minimizing changes to surrounding code.
Anyhow, I was just wondering about that.
--
Cheers
David / dhildenb
